From e135354d00421e2a61db5027e40bab752db6baec Mon Sep 17 00:00:00 2001 From: adamtoms Date: Sun, 23 Oct 2022 20:10:22 +0100 Subject: [PATCH] main .sh updated to resove two bugs When running with only one cpu Dell_iDRAC_fan_controller.sh: line 69: [: -gt: unary operator expected, resolved by adding double brackets. 113 split onto two lines to prevent Dell_iDRAC_fan_controller.sh: line 113: printf: User static fan control profile (20%): invalid number changed %40s to %s and split over two lines. Removed warning. --- Dell_iDRAC_fan_controller.sh | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/Dell_iDRAC_fan_controller.sh b/Dell_iDRAC_fan_controller.sh index 0bab993..8ab10ca 100644 --- a/Dell_iDRAC_fan_controller.sh +++ b/Dell_iDRAC_fan_controller.sh @@ -65,8 +65,8 @@ while true; do CPU1_TEMPERATURE=$(echo $CPU_DATA | awk '{print $1;}') CPU2_TEMPERATURE=$(echo $CPU_DATA | awk '{print $2;}') - CPU1_OVERHEAT () { [ $CPU1_TEMPERATURE -gt $CPU_TEMPERATURE_TRESHOLD ]; } - CPU2_OVERHEAT () { [ $CPU2_TEMPERATURE -gt $CPU_TEMPERATURE_TRESHOLD ]; } + CPU1_OVERHEAT () { [[ $CPU1_TEMPERATURE -gt $CPU_TEMPERATURE_TRESHOLD ]]; } + CPU2_OVERHEAT () { [[ $CPU2_TEMPERATURE -gt $CPU_TEMPERATURE_TRESHOLD ]]; } COMMENT=" -" if CPU1_OVERHEAT @@ -110,8 +110,9 @@ while true; do echo " Date & time Inlet CPU 1 CPU 2 Exhaust Active fan speed profile Comment" i=0 fi - printf "%12s %3d°C %3d°C %3d°C %5d°C %40s %s\n" "$(date +"%d-%m-%y %H:%M:%S")" $INLET_TEMPERATURE $CPU1_TEMPERATURE $CPU2_TEMPERATURE $EXHAUST_TEMPERATURE "$CURRENT_FAN_CONTROL_PROFILE" "$COMMENT" - + printf "%12s %3d C %3d C %3d C %5d C" "$(date +"%d-%m-%y %H:%M:%S")" $INLET_TEMPERATURE $CPU1_TEMPERATURE $CPU2_TEMPERATURE + printf " %s %s\n" "$CURRENT_FAN_CONTROL_PROFILE" "$COMMENT" + ((i++)) wait $SLEEP_PROCESS_PID done